[MPlayer-dev-eng] [PATCH] behaviour of 'a' key and sub alignment

Diego Biurrun diego at biurrun.de
Mon Oct 24 23:16:34 CEST 2005


On Mon, Oct 24, 2005 at 10:46:02PM +0200, Paul TT wrote:
> On Mon, 24 Oct 2005 12:36:24 -0400
> Rich Felker <dalias at aerifal.cx> wrote:
> 
> > On Mon, Oct 24, 2005 at 05:04:19PM +0200, Paul TT wrote:
> > > 
> > > I read about IRC discussion in the other thread, but the result
> > > is that when i am playing something with subs and i press 'a' it
> > > still tell me 'bottom' when they are top-aligned and 'top' when
> > > they're bottom-aligned.....
> > 
> > RTFM; you're just misunderstanding the word "align". Subs have always
> > been correctly aligned.
> 
> mhhh, in TFM there is no definition of 'align'...
> it's only specified the meaning of 0,1,2
> AFAIK top means above, bottom means below.
> so if this is right mplayer works wrong.
> 
> if the following is the area of the subs:
> +---------+
> |         |
> |         |
> |         |
> +---------+
> the way mplayer subalign works is as it follows:
>      +---------+
> 2->  |subtitle2|
> 1->  |subtitle1|
> 0->  |subtitle0|
>      +---------+
> 
> and this way works the 'a' key switch.
> but when the sub is at top, as TFM says, it should be at 0, instead 0
> is renderered as the bottom... 
> and 2 as top position, and this conflicts with TFM. so or TFM is wrong
> or libvo/subs.c goes wrong.

IIUC it's meant to be as follows:


bottom alignment:

  the bottom of this subtitle is aligned with the subtitle position
  ----------this---line---is---the---subtitle---position-----------

center alignment:

  ----this--subtitle--is--centered--on--the--subtitle--position----

top alignment:

  --------this---line---is---the---subtitle---position----------
  the top of this subtitle is aligned with the subtitle position


Does that clarify things?  Probably the man page needs to explain things
better still...

Diego




More information about the MPlayer-dev-eng mailing list