[MPlayer-dev-eng] [PATCH]warning about bad timing in a subtitle line

[Adam Tlałka]

Dnia Fri, 14 Oct 2005 13:19:09 +0200, Attila Kinali <attila at kinali.ch>  
napisał:

> Have you read the output of your patch?
>
> SUB:23:Huston we have a Problem
>
> If i'd see something like that i would immediately ask
> myself what the heck the one who wrote this crappy
> message meant.

Line nr 23 with begins with text "Huston we..." has some timing errors.
So OK it is not very understandable message.
Maybe I should generate more verbouse one i.e:
SUB:23: end time after next subtitle start time :)?

> Well, MPlayer corrects it already.
I know that!! It's rather obvious if it detects those kind
of situactions so it can correct them.

> And if you really want to fix your sub files, then you
> should write a perl script that does it. It's
> not only simpler to write it in perl, no it can be even
> written in a way that can cope easily with different
> sub file formats and fix them in a way the user wants it.

I don't want a whole pack of stuff to work with subtitles.
Just MPlayer and Vim fits my needs. Is it wrong?

> IMHO fixing sub files belongs really into a script in the
> TOOLS directory instead of MPlayer.

Probably it is the correct place for a some kind of script.
But we are talking only abut sygnalling some problems
with subtitles by MPlayer.

> Oh, quite simple: With a compiler you have code written
> _by_yourself_ and want to see whether it has any problems.
> Not to talk about that you have to explicitly switch these
> warnings on (warnings are nearly completely off by default on
> any compiler i know).

And I switch them. I very often doing compilation with -Wall set.

> Here we are dealing with files that we got _from_somewhere_else_.

True.

> We do not want to know whether they are correct or not.

But maybe some user cares.

> LOL. How many users do READ the MPlayer output ?

I do. There are some others probably too ;-)

> MPlayer is already oververbose so that it is already
> quite hard to see the information that is relevant.

Not so bad and you can always do 2>/dev/null .

> Adding more messages here is not only, as you put it,
> inconvenient but decreases usability.

I said that inconvinient is running MPlayer twice.

> If you want to waste your time fixing this patch, be my guest.
> But i see no sense in it and i doubt it will be commited
> by anyone else.

I see some sense in it.

> You should rather concentrate your energy on things that matter.

Usability always matters.

Regards
-- 
Adam Tlałka      mailto:atlka at pg.gda.pl    ^v^ ^v^ ^v^
System  & Network Administration Group           ~~~~~~
Computer Center,  Gdańsk University of Technology, Poland
PGP public key:   finger atlka at sunrise.pg.gda.pl