[MPlayer-dev-eng] [PATCH]warning about bad timing in a subtitle line

[Adam Tlałka]

Dnia Fri, 14 Oct 2005 15:10:49 +0200, Ivan Kalvachev  
<ikalvachev at gmail.com> napisał:

> MPlayer correction may not do the thing you hope.
> The problem comes that mplayer supports overlapped subtitles.  It only
> correct subtitles that overlap by a little (to prevent visible
> flashing with unreadable speed).

Hmm, I've just looked at the subreader.c CVS code and something
looks wrong here.
Actually the "block" variable is set to 1 when we do not overlap
which seems to be OK but as we dig in the adjust_subs_time() function
we spot that in situaction when "block" is 0 no correction is done at all.
Also there is an error in correction code in case of time format of  
subtitles.
Correction by 1 is not good because it means 1 frame in frame format but
in situaction when we use a time format it leads to the bad result
- real video frame of end of subtitle and start of the next one could
be the same because 1 means 1/100 sec if sub_uses_time is set.

So here is my patch which makes MPlayer to work as you said.
Subtitles are corrected a little if we do overlapping and corrected
hard ;) if not. Comments in the code are corrected.
Time format problem is also corrected I think.
No warnings.

Regards
-- 
Adam Tlałka      mailto:atlka at pg.gda.pl    ^v^ ^v^ ^v^
System  & Network Administration Group           ~~~~~~
Computer Center,  Gdańsk University of Technology, Poland
PGP public key:   finger atlka at sunrise.pg.gda.pl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 3a.patch
Type: application/octet-stream
Size: 2353 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20051015/d8c0cc18/attachment.obj>