[MPlayer-dev-eng] Re: [PATCH-RFC] Implementing the osd preferences menu

[Alban Bedel]

On Wed, 12 Oct 2005 13:18:40 +0200
Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:

> Hi,
> On Wed, Oct 12, 2005 at 12:39:01PM +0200, Alban Bedel wrote:
> > If the patch is really too hard to digest i can try to split it (ie: first
> > the osd part, then the property stuff). Althought that would mean a lot of
> > useless work (bcs quiet some code would have to be changed in one step to
> > be just removed in the next), i could do it if that help getting feedback.
> 
> It's really a huge patch, I never like these.

I understand that, but i had to make sure everthing work together nicely.
And well, when one work on main() it's hard to make small changes.
Anyway i'm gonna try to split more stuff and be more incremental. 

> Also there are some cosmetic changes, and also the printf changes etc.

I know, again it's an RFC. As you know mplayer.c is full of gratious
warnings that should have been fixed long ago, so i had to kill some of
them to be able to read those concerning my changes.

> should be done seperately, as well as that yes/no -> enabled/disabled
> change (I'm not sure if it is a good idea at all).

The original reason behind that change is the osd. Currently it print things
like: "Subtitle: enabled". So i wanted it to still print the same thing and
not "Subtitle: yes".
After some reflection i thought it make more sense anyway. When printing
the state of a flag en/disabled seems much more appropriate than yes/no.
As the output of the print functions should be parsable again, i also
added en/disable(d) to the possible keywords for flags. The only side
effect is that ppl can then write things like "framedrop=enable" in their
config file. No big deal, just one more hidden feature ;)

	Albeu