[MPlayer-dev-eng] Re: [PATCH-RFC] Implementing the osd preferences menu

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Wed Oct 12 13:18:40 CEST 2005


Hi,
On Wed, Oct 12, 2005 at 12:39:01PM +0200, Alban Bedel wrote:
> If the patch is really too hard to digest i can try to split it (ie: first
> the osd part, then the property stuff). Althought that would mean a lot of
> useless work (bcs quiet some code would have to be changed in one step to
> be just removed in the next), i could do it if that help getting feedback.

It's really a huge patch, I never like these.
Also there are some cosmetic changes, and also the printf changes etc.
should be done seperately, as well as that yes/no -> enabled/disabled
change (I'm not sure if it is a good idea at all).

Greetings,
Reimar Döffinger




More information about the MPlayer-dev-eng mailing list