[MPlayer-dev-eng] [PATCH]cr/lf line endings of dumped subtitles

[Adam Tlałka]

Dnia Wed, 12 Oct 2005 19:49:39 +0200, Joey Parrish <joey at nicewarrior.org>  
napisał:

> On Wed, Oct 12, 2005 at 06:05:20PM +0200, Adam Tla??ka wrote:
>> >>2.patch -> subreader.c: cr/lf line ending output of subtitle dump file
>> >>format added
>> >>The output file is openned in "wb" mode so we always get what we  
>> write.
>
>> After all this flame war I can't see strong points in Ritch's
>> argumentation.
>> I am not convinced.
>> So the patch is as is.
>> Of course changeing JACOsub and mpsub format by me was a mistake.
>> But not in other cases. I just can't make it optional if it should
>> be the standard.
>> So now you must decide.
>> Accept or reject or do it other way.
>> It's up to you as it always be :-)
>
>> >Please ignore this patch. If Adam still refuses to send a correct
>> >patch I will write one myself in a few days.
>
>> You are the code master but that doesn't automatically mean that you are
>> right.
>> But the choise is of course yours.
>
> Please, Adam.  If he's offering an alternative solution, then wait for
> his patch before shooting off your mouth.  Compare his solution to
> yours.  For example, say you see his patch and it's got an option to
> change line-endings.  You could then just stick end=crlf or whatever in
> mplayer config file and forget about it.  Everyone's happy.  You and
> Rich both get what you wanted.

I generally do not agree with that solution. But if you have to do it this
way then I suggest end=original or end=native options with appropriate
man page and help explanation.
But I will not write a patch because I am not convinced to making this
an option.

> So just be patient, please.  This whole issue should be over soon.
So I will. :)

Thanks
-- 
Adam Tlałka      mailto:atlka at pg.gda.pl    ^v^ ^v^ ^v^
System  & Network Administration Group           ~~~~~~
Computer Center,  Gdańsk University of Technology, Poland
PGP public key:   finger atlka at sunrise.pg.gda.pl