[MPlayer-dev-eng] [PATCH]cr/lf line endings of dumped subtitles

[Joey Parrish]

On Wed, Oct 12, 2005 at 06:05:20PM +0200, Adam Tla??ka wrote:
> >>2.patch -> subreader.c: cr/lf line ending output of subtitle dump file
> >>format added
> >>The output file is openned in "wb" mode so we always get what we write.

> After all this flame war I can't see strong points in Ritch's  
> argumentation.
> I am not convinced.
> So the patch is as is.
> Of course changeing JACOsub and mpsub format by me was a mistake.
> But not in other cases. I just can't make it optional if it should
> be the standard.
> So now you must decide.
> Accept or reject or do it other way.
> It's up to you as it always be :-)

> >Please ignore this patch. If Adam still refuses to send a correct
> >patch I will write one myself in a few days.

> You are the code master but that doesn't automatically mean that you are  
> right.
> But the choise is of course yours.

Please, Adam.  If he's offering an alternative solution, then wait for
his patch before shooting off your mouth.  Compare his solution to
yours.  For example, say you see his patch and it's got an option to
change line-endings.  You could then just stick end=crlf or whatever in
mplayer config file and forget about it.  Everyone's happy.  You and
Rich both get what you wanted.

So just be patient, please.  This whole issue should be over soon.

Thanks,
--Joey

-- 
"I tell you:  one must still have chaos in oneself to give
birth to a dancing star!" --Nietzsche