[MPlayer-dev-eng] [PATCH]breakline properly with subtitles using Chinese

[陆然]

Hi,

> Perhaps the original proposal would be ok if you s/asian/CJK/. I just
> don't know. But it's definitely not acceptable doing this for all
> chars > 0x800!

You are perfectly right, I admit I was a little bit lazy here, and I should 
say CJK instead of  asian. I was not aware of Thai and Tibetan problem :(.  
So, how about change the condition to chars > 0x2000, I think it will safely 
avoid Thai or Tibetan or other languages, and keep all the relevant CJK 
chars. Here is a unicode table you may check for yourselves.

http://ppewww.ph.gla.ac.uk/~flavell/unicode/unidata.html

BTW, maybe you will suggest a more conservative value (0x2E00 maybe), the 
problem is, that condition will treat the chars and the puncts differently,  
you may see a right double quotation mark at the start of a line for example. 
and these puncts are scattered in the table, if we want to treat them 
differently, we will need a database.

And about you suggestion to write the subtitle properly, it's not the 
subtitles fault. if the subfont-text-scale is not small enough this will 
happen, however there is no universal vaule to fit all the different 
subtitles, and we should not require them to add white space just for 
mplayer, right ;)

-- 
Best Regards,
LR
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20051125/52cbfb60/attachment.pgp>