[MPlayer-dev-eng] [PATCH] misc small fixes (mostly gcc warnings)

[Rich Felker]

On Mon, Nov 14, 2005 at 11:12:50AM +0100, Diego Biurrun wrote:
> On Sun, Nov 13, 2005 at 11:48:49PM -0500, Rich Felker wrote:
> > On Sun, Nov 13, 2005 at 08:07:24PM +0100, Roberto Togni wrote:
> > >
> > > There was both seek functions returning int and seek functions
> > > returning void before the demuxer patch, but in every case the return
> > > value was ignored. Probably i forgot to change these to void. If we
> > > prefer to change them all to int we can talk about it, but if we don't
> > > do anything with the result i see no reason to do it.
> > 
> > Even if we presently do nothing with the return value, getting rid of
> > in in the demuxers that supported return codes is destroying
> > functionality that was there and making the code more difficult to
> > read. I'm against any solution that removes the return values where
> > they already existed.
> 
> Well, since they are ignored anyway, I don't think removing them should
> be such a problem.  We can put adding proper return values on the TODO.

Presently:

Reading a seek function, it's clear which return points are success
and which ones are failure.

With the proposed change:

No way of telling except reading the actual code and deciding for
yourself whether the case is a success case or a failure case.

I'm against changes that remove this kind of meaning from code.

Rich