[MPlayer-dev-eng] [PATCH] misc small fixes (mostly gcc warnings)

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Mon Nov 14 15:31:11 CET 2005


Hi,
On Sun, Nov 13, 2005 at 11:48:49PM -0500, Rich Felker wrote:
> Even if we presently do nothing with the return value, getting rid of
> in in the demuxers that supported return codes is destroying
> functionality that was there and making the code more difficult to
> read. I'm against any solution that removes the return values where
> they already existed.

Nice theory, but in practice when they aren't used, the values that are
returned are usually bogus and makes things even more complicated when
you want to actually make use of them - I encoutered that kind of thing
in other places already.
In other words: Either give them a reason to exist or remove them.
Anything else is endorsing broken cruft, which I think we have enough
of.

Greetings,
Reimar Döffinger




More information about the MPlayer-dev-eng mailing list