[MPlayer-dev-eng] [PATCH] OSD localization second try

[Diego Biurrun]

On Fri, Nov 04, 2005 at 12:50:15AM +0100, Paul TT wrote:
> On Thu, 3 Nov 2005 20:21:32 +0100
> Diego Biurrun <diego at biurrun.de> wrote:
> 
> > On Thu, Nov 03, 2005 at 02:02:34AM +0100, Paul TT wrote:
> > > 
> > > can i apply the patch if ok?
> > 
> > I have an objection..
> > 
> ...
>  
> > > +#define MSGTR_OSDenabled "en"
> > > +#define MSGTR_OSDdisabled "dis"
> > > +#define MSGTR_OSDSubtitles "Subtitles: %sabled"
> > > +#define MSGTR_OSDStayOnTop "Stay on top: %sabled"
> > > +#define MSGTR_OSDRootwin "Rootwin: %sabled"
> > > +#define MSGTR_OSDosd "OSD: %sabled"
> > 
> > I think this is going to be impossible to translate to all languages. 
> I
> > suppose you will have to just create different messages.
> 
> yes, indeed i was doubtful about those.... i'll change en to enabled
> and dis to disabled, and subsequently %sabled to %s in the other
> messages...

Just to clarify since you are new around here: When one of the other
devs has an objection to a patch you posted, you are expected to come up
with an updated version that resolves the objection. Alternatively you
can give good reasons why you did things the way you did and believe you
are right anyway.

Disregard this mail if this was clear to you all along.

Diego