[MPlayer-dev-eng] [PATCH] VIA Unichrome support

[Reimar Döffinger]

Hi,
On Sun, May 08, 2005 at 09:19:31AM +0100, Ivor Hewitt wrote:
> On Saturday 07 May 2005 22:15, Reimar Döffinger wrote:
> > On Sat, May 07, 2005 at 09:27:04PM +0100, Ivor Hewitt wrote:
> > > -      XvMCDestroyMacroBlocks(mDisplay,&mv_blocks);
> > > -      XvMCDestroyBlocks(mDisplay,&data_blocks);
> > > -
> > > +      if (!hasVLDAcceleration())
> > > +      {
> > > +         XvMCDestroyMacroBlocks(mDisplay,&mv_blocks);
> > > +         XvMCDestroyBlocks(mDisplay,&data_blocks);
> > > +      }
> >
> > I personnally would prefer it if you didn't change the indentation of
> > these two lines...
> >
> But thats crazy. The lines are now inside a conditional block, they 'should' 
> be indented.

Not the same discussion within two days :-(... Please read this thread -
in case you then have any new arguments, I'd be happy to hear them. But
I doubt it, this was discussed so often already
http://mplayerhq.hu/pipermail/mplayer-cvslog/2005-May/021680.html

[...]
> > > -#ifdef HAVE_XVMC
> > > -    if(s->avctx->xvmc_acceleration)
> > > +#if defined(HAVE_XVMC)|defined(HAVE_XVMC_VLD)
> > > +    if(s->avctx->xvmc_acceleration)
> >
> > Hm.. What's the difference in these two if lines?
> >
> "_VLD" 

Not the #if lines, the if( lines!

Greetings,
Reimar Döffinger