[MPlayer-dev-eng] [PATCH] subtitle reload, slave mode - 5th try

[Salvatore Falco]

On Mon, Mar 07, 2005 at 10:19:11PM -0500, kiriuja wrote:
> > Ok, again with the slave commands that load and reaload the subtitles.
> > This pathc adds three commands for slave mode to load and reload and
> > remove subtitles at runtime.
> 
> In your load_subtitles_file you duplicated all the code from
> add_subtitles, but lost the -identify part. Instead you should call
> add_subtitles and change it to return sub_data*.

    OK, I'll do that. But note that add_subtitles does not handle correctly
global_sub_size, which, I understand, is used to store all the subs loaded.

> 
> Also, what happened to the OSD problem you mentioned in your previous
> post? Were you able to solve it?
> http://mplayerhq.hu/pipermail/mplayer-dev-eng/2004-October/030776.html

    No. It is hard to reproduce, but, from my understanding, is not
related to subtitle loading, since it happens also with unpatched MPlayer.

> Also, now that -identify prints out all subtitle ids it actually loads,
> referring to previously loaded subtitles by paths rather than indexes
> is complete nonsense, and your for/strcmp code is totally redundant.

    How should I use a _printed_ id? These commands are intended to be used
in slave mode.
 
> Also, you have a bunch of strdups in there, but it is not clear where
> that memory is freed. Do you really need those strdups?

    Copies are freed with the subtitles, originals are command line options,
and I don't know when they are freed, therefore I did not assume they are
always available.

> --
> kiriuja

-- 
salvatore falco