[MPlayer-dev-eng] New remove-logo filter

Michael Niedermayer michaelni at gmx.at
Thu Mar 3 19:06:24 CET 2005


Hi

On Thursday 03 March 2005 17:41, D Richard Felker III wrote:
> On Thu, Mar 03, 2005 at 12:48:22PM +0100, Diego Biurrun wrote:
> > On Thu, Mar 03, 2005 at 01:35:47PM +0200, Oded Shimon wrote:
> > > BTW, since you
> > > seen to like comments so much, you might want to use doxygen comments.
> > > They are pretty much the same as you have now, just built for
> > > doxygen... Check DOCS/tech/code-documentation.txt .
> >
> > Besides, they are mandatory now, so without them your patch is rejected.
>
> Rejection rejected. We already discussed this on irc...his code is so
> excessively verbose that the LAST thing we want is more comments to
> bloat it up more!
> Besides, demanding code documentation for filters is nonsense. It's

IMHO the comments which are already there really should be changed to conform 
to the doxygen syntax

[...]
-- 
Michael

"nothing is evil in the beginning. Even Sauron was not so." -- Elrond




More information about the MPlayer-dev-eng mailing list