[MPlayer-dev-eng] [PATCH] libmplayer

[The Wanderer]

Nico Sabbi wrote:

> The Wanderer wrote:
> 
>>> +    if(!quiet)
>>> +    {
>>> +        // TODO : should probably have a Resumed msg
>>> +        printf("                       \n"); //clear pause and go to next line
>>
>> Please do not use printf except in debugging code, i.e. commented
>> out or inside #if 0 (and ideally not then either)
> 
> IMO even if  surrounded by #if 0/#endif blocks there's no reason not
> to replace it with mp_msg with MSGL_INFO loglevel

That would be my position as well (except perhaps for the MSGL), and I
might extend that even to commented-out lines (against, say, the
possibility of wanting to both send video/audio to stdout *and* get
debug output), but I believe that some of the people who do most of the
work here have disagreed with me.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

A government exists to serve its citizens, not to control them.