[MPlayer-dev-eng] [PATCH] libmplayer

[Bryan Wilkerson]

--- The Wanderer <inverseparadox at comcast.net> wrote:

> Bryan Wilkerson wrote:
> 
> > +	if(!quiet)
> > +	{
> > +		// TODO : should probably have a Resumed msg
> > +		printf("                       \n"); //clear
> pause and go to next line
> 
> Please do not use printf except in debugging code,
> i.e. commented out or
> inside #if 0 (and ideally not then either), both
> because it precludes
> the possibility of sending output to stdout and -
> notably in the current
> case - because an underlying library should AFAIK
> never use stdout. Use
> mp_msg instead. 

Sorry, missed that one.  Attached is the updated
patch.

-bryan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-libmplayer.diff
Type: text/x-patch
Size: 81121 bytes
Desc: 2374417340-mplayer-libmplayer.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050617/a8f78779/attachment.bin>