[MPlayer-dev-eng] Re: Re: Re: fast SPP - working code

[Jindrich Makovicka]

Oded Shimon wrote:
> On Sat, Jun 04, 2005 at 02:42:04PM +0200, Jindrich Makovicka wrote:
> 
>>Ismail Donmez wrote:
>>
>>>On Saturday 04 June 2005 14:13, Bohdan Horst wrote:
>>>
>>>
>>>>On Sat, Jun 04, 2005 at 09:50:55AM +0200, Jindrich Makovicka wrote:
>>>>
>>>>
>>>>>Rich Felker wrote:
>>>>>
>>>>>
>>>>>>IMO if it behaves differently from current spp, or has different
>>>>>>featureset (I seem to remember this being the case) then we should
>>>>>>give it a different name and leave both in place. Otherwise, feel free
>>>>>>to commit as soon as the code is confirmed to compile (including on
>>>>>>gcc 2.95) and basically work. :)
>>>>>
>>>>>committed as -vf fspp
>>>
>>>
>>>This doesn't compile on amd64 :
>>>
>>
>>[...]
>>
>>The code would require replacing gp registers with REG_* macros. I will
>>disable the mmx optimizations for now on x86-x64, until someone fixes it.
> 
> 
> I JUST fixed it, but apperantely I didn't.
> 
> {standard input}:791: Error: Incorrect register `%rdx' used with `l' suffix
> {standard input}:800: Error: Incorrect register `%rsi' used with `l' suffix
> 
> Apperantely using commands like 'addl' on those registers is obviously 
> illegal.. I'm not sure what to do at this point, i've never made 64-bit 
> code...

I think that most of them should be just replaced with the instructions
without the suffix (addl->add). But I didn't code any 64bit asm either.

-- 
Jindrich Makovicka