[MPlayer-dev-eng] [PATCH] MinGW compile fix, header order policy suggestion
Reimar.Doeffinger at stud.uni-karlsruhe.de
Thu Jun 2 21:04:40 CEST 2005
On Mon, May 30, 2005 at 10:39:46AM +0200, Reimar D?ffinger wrote:
> the attached patch changes the order of the header in some files so that
> system headers always come first. The point is that windows headers
> define a STREAM_SEEK, too (in the way typedef struct ... STREAM_SEEK),
> if in this case our STREAM_SEEK is already defined it won't compile.
> I'd also suggest to adding something like: "you should first #include
> config.h, then any system header and last the MPlayer specific one. If
> can't do it like this for some reason, comment it in the code!"
> to the CVS policy.
> What do you think?
Applied to at least fix compilation, we can still change it if this
discussion actually leads to anything...
More information about the MPlayer-dev-eng