[MPlayer-dev-eng] [PATCH] MinGW compile fix, header order policy suggestion
Diego Biurrun
diego at biurrun.de
Fri Jun 3 00:57:54 CEST 2005
On Thu, Jun 02, 2005 at 09:04:40PM +0200, Reimar Döffinger wrote:
> On Mon, May 30, 2005 at 10:39:46AM +0200, Reimar D?ffinger wrote:
> > the attached patch changes the order of the header in some files so that
> > system headers always come first. The point is that windows headers
> > define a STREAM_SEEK, too (in the way typedef struct ... STREAM_SEEK),
> > if in this case our STREAM_SEEK is already defined it won't compile.
> > I'd also suggest to adding something like: "you should first #include
> > config.h, then any system header and last the MPlayer specific one. If
> > can't do it like this for some reason, comment it in the code!"
> > to the CVS policy.
> > What do you think?
>
> Applied to at least fix compilation, we can still change it if this
> discussion actually leads to anything...
Trust grandpa on this one: It won't ;-)
Diego
More information about the MPlayer-dev-eng
mailing list