[MPlayer-dev-eng] [PATCH] make sub_read_file strdup the filename

[Reimar Döffinger]

Hi,
On Fri, May 27, 2005 at 05:39:45PM +0200, Reimar D?ffinger wrote:
> On Fri, May 27, 2005 at 04:57:38PM +0200, Reimar D?ffinger wrote:
> > since it is at the moment use incorrectly in mplayer.c and even in its
> > own "sample" code in subreader.c (not to mention that I hate the current
> > semantics), this patch makes sub_read_file strdup the filename for
> > storing it in subt_data.
> > It will make the memleak in mencoder.c a tiny bit bigger (where in
> > addition was also used incorrectly before well by passing "default"),
> > but compared to the leak caused by not freeing the results of get_path
> > and sub_filenames that's negligable.
> 
> Fixed that memleak.

Applied, with fixed mencoder part (forgot to check for tmp == NULL at
two places).

Greetings,
Reimar Döffinger