[MPlayer-dev-eng] [PATCH] MinGW compile fix, header order policy suggestion

Rich Felker dalias at aerifal.cx
Thu Jun 2 21:26:24 CEST 2005


On Thu, Jun 02, 2005 at 01:41:08PM -0500, Joey Parrish wrote:
> On Thu, Jun 02, 2005 at 01:19:31PM -0400, Rich Felker wrote:
> > > from us.)  Renaming to MP_STREAM_SEEK is a better idea, IMHO, because
> > > then we aren't fighting a namespace war against an OS who cares nothing
> > > for open source devs.
> > 
> > And should we obfuscate every single symbol in MPlayer like this? NO!
> > There is no war unless we use broken mingw headers. Just remove them
> > and prototype the 5 or 10 functions you need manually.
> 
> It's not obfuscation!  It's a very simple renaming of 1 symbol.
> And since it's only for use internally in MPlayer, we can call it
> whatever we like.  We don't have to keep STREAM_SEEK for compatibility
> with some other app.  Why is this such a big deal?

Because there are correct ways to fix the problem. You want to treat
the symptoms rather than the problem, which is that the windows
headers are broken crap.

Rich




More information about the MPlayer-dev-eng mailing list