[MPlayer-dev-eng] [PATCH] CQMs in x264

[Robert Swain]

Hello.

On 7/26/05, Diego Biurrun <diego at biurrun.de> wrote:
> On Tue, Jul 26, 2005 at 02:26:43AM +0100, Robert Swain wrote:
> > I posted an updated patch earlier, after saying what I said. What do
> > you think of that one? It looks fine in man. What do you suggest I
> > change '<option>' to? There are three options - flat, jvt and
> > <filename>, as noted in the documentation.
> 
> something along the lines of
> 
> cqm[=<flat | jvt | <filename> >]
> 
> Look around the man page for examples.

I've used the xvid quant_type style and gone for cqm=<jvt|flat|<filename>>.

> > I did the documentation based on copy and paste and a bit of
> > guesswork. It all looks fine using man so how am I supposed to know
> > what's wrong with it?
> 
> Are we talking about the same patch?  mplayer.x264.cqm.9.diff?
> 
> Look at the formatting in man again, the paragraph indentation is wrong,
> it does not resemble the other options at all.

Apologies, I thought I'd sent the patch to the ML, it turns out I'd
only sent it to someone privately. :) Please find revision 11
attached.

I'd like to have a line space after "The provided JM format matrix
file is used." but everything I try breaks it. Otherwise it really
does look fine to me. Is it worth adding a note for windows users that
they won't be able to use full lists with cmd.exe because the
commandline length is too great? And also that there is no way to pass
absolute paths using cmd.exe because of ':'?

Robert Swain (superdump)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer.x264.cqm.11.diff
Type: application/octet-stream
Size: 8282 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050726/b35a02cb/attachment.obj>