[MPlayer-dev-eng] [PATCH] CQMs in x264

[Diego Biurrun]

On Tue, Jul 26, 2005 at 02:26:43AM +0100, Robert Swain wrote:
> On 7/26/05, Diego Biurrun <diego at biurrun.de> wrote:
> > I'd appreciate if you could fix it, right now it's completely broken.
> > The formatting is all messed up and I suspect the : after the option
> > names are wrong.  Also, cqm=<option> should be replaced by something
> > more descriptive, similar to zones=<zone0>[/<zone1>[/...]].
> > 
> > Just look around the man page sources and do some copy + paste, it's not
> > that hard.  This cannot be applied in the state it's in right now.
> 
> I posted an updated patch earlier, after saying what I said. What do
> you think of that one? It looks fine in man. What do you suggest I
> change '<option>' to? There are three options - flat, jvt and
> <filename>, as noted in the documentation.

something along the lines of

cqm[=<flat | jvt | <filename> >]

Look around the man page for examples.

> I did the documentation based on copy and paste and a bit of
> guesswork. It all looks fine using man so how am I supposed to know
> what's wrong with it?

Are we talking about the same patch?  mplayer.x264.cqm.9.diff?

Look at the formatting in man again, the paragraph indentation is wrong,
it does not resemble the other options at all.

Diego