[MPlayer-dev-eng] [PATCH] CQMs in x264

[Guillaume POIRIER]

Hi,

On 7/15/05, Robert Swain <robert.swain at gmail.com> wrote:
> On 7/15/05, Diego Biurrun <diego at biurrun.de> wrote:
> > On Fri, Jul 15, 2005 at 01:55:04PM +0100, Robert Swain wrote:
> > > But the CQM not
> > > loaded message is an error, so should this have remained MSGL_ERR?
> >
> > I don't remember off the top of my head if that error was fatal and if
> > it is a real error or just a warning.  Choose from
> >
> > #define MSGL_FATAL 0  // will exit/abort
> > #define MSGL_ERR 1    // continues
> > #define MSGL_WARN 2   // only warning
> > #define MSGL_HINT 3   // short help message
> 
> I'll go with MSGL_ERR because the user wanted to use a CQM but it
> didn't load correctly either because they specified an invalid choice
> or because the file is not of the correct format. As far as I know
> command line errors are errors - "Error parsing command line."
> 
> Patch attached.

Loren, you maintain that part of MEncoder, what do you think about it?
Should it get applied?

Robert, could you please send a CQM here, and I'll try to find a good
way to put an example somewhere. The HTML doc already features CQM
example for lavc, so I think I'll add it there.

Regards,
Guillaume
-- 
A lie gets halfway around the world before the truth has a chance to
get its pants on.
 -- Winston Churchill