[MPlayer-dev-eng] [PATCH] CQMs in x264

Robert Swain robert.swain at gmail.com
Fri Jul 15 19:48:58 CEST 2005


On 7/15/05, Diego Biurrun <diego at biurrun.de> wrote:
> On Fri, Jul 15, 2005 at 01:55:04PM +0100, Robert Swain wrote:
> > But the CQM not
> > loaded message is an error, so should this have remained MSGL_ERR?
> 
> I don't remember off the top of my head if that error was fatal and if
> it is a real error or just a warning.  Choose from
> 
> #define MSGL_FATAL 0  // will exit/abort
> #define MSGL_ERR 1    // continues
> #define MSGL_WARN 2   // only warning
> #define MSGL_HINT 3   // short help message

I'll go with MSGL_ERR because the user wanted to use a CQM but it
didn't load correctly either because they specified an invalid choice
or because the file is not of the correct format. As far as I know
command line errors are errors - "Error parsing command line."

Patch attached.

Thanks again everyone,
Robert Swain (superdump)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer.x264.cqm.5.diff
Type: application/octet-stream
Size: 2629 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050715/8d55f289/attachment.obj>


More information about the MPlayer-dev-eng mailing list