[MPlayer-dev-eng] [PATCH] CQMs in x264

[Diego Biurrun]

On Fri, Jul 15, 2005 at 01:55:04PM +0100, Robert Swain wrote:
> 
> On 7/15/05, Diego Biurrun <diego at biurrun.de> wrote:
> > That's not a good idea IMO, MPlayer/MEncoder are already too verbose, we
> > should not add to that verbosity.  It's OK to get that info in verbose
> > mode, otherwise any good Unix tool remains silent unless there is an
> > error.
> 
> OK. What level do you suggest? After reading the man page MSGL_V seems
> appropriate for the CQM correctly loaded message.

Yes, that should be OK, maybe even DBG2, decide for yourself.

> But the CQM not
> loaded message is an error, so should this have remained MSGL_ERR?

I don't remember off the top of my head if that error was fatal and if
it is a real error or just a warning.  Choose from

#define MSGL_FATAL 0  // will exit/abort
#define MSGL_ERR 1    // continues
#define MSGL_WARN 2   // only warning
#define MSGL_HINT 3   // short help message

> The punctuation will be corrected in the next patch. I will update the
> patch once I obtain clarity regarding the message levels. :)

Good.

Diego