[MPlayer-dev-eng] [patch] libpostproc fix for negative strides

[Michael Niedermayer]

Hi

On Wednesday 23 February 2005 16:20, Jindrich Makovicka wrote:
> Hi,
>
> the attached patch fixes libpostproc crashes with negative strides (Bug
> #191).

[...]
>
> for(i=0; i<(count>>2); i++){
>-        ((uint32_t*)c->nonBQPTable)[i] = ((uint32_t*)QP_store)[i] & 
>0x3F3F3F3F;
>+    ((uint32_t*)c->nonBQPTable)[i] = ((uint32_t*)QP_store)[i] & 0x3F3F3F3F;
> }

cosmetic


>                if(width==dstStride)
>+                   if (dstStride > 0)

this looks suspicious


many of the memcpy special cases could also probably be avoided by writing a 
memcpy wraper which supports stride<0

furthermore the case with src_stride<0 && dst_stride<0 is unneeded to be 
handled, both can just be flipped

and some '-vo md5' tests of all pp filters both in c and mmx would be nice too


-- 
Michael

"nothing is evil in the beginning. Even Sauron was not so." -- Elrond