[MPlayer-dev-eng] [PATCH] Set liba52 output volume

Zoltan Hidvegi mplayer at hzoli.2y.net
Tue Feb 15 20:25:49 CET 2005


Reimar Döffinger wrote:
> I know that your patch doesn't add stupid conversions, but I know that
> there are such internal conversions (at least in af_ladspa.c,
> ad_libmad.c and the first version of ad_mpc.c)
> Whether it works or not, it should be fixed instead at the place where
> it is broken instead of constantly working around it.
> Also I'd really like this functionality to be available in a more
> general way... If you have time, maybe look if you can support for this
> control to mixer.c? It would then only work with -softvol at first, but
> better than nothing IMHO (and we already have so many options ;-) )

As much as I can tell, mixer.c does not have easy access to the ad.  I
will try to modify liba52 to output float, then you can use -af volume
which can be controlled by the mixer.  Using -af volume is a bit
slower than setting the level in liba52, it adds sample_rate *
channels number of float multiplys per seconds.  But it's negligible
on most current machines with a decent FP unit, and could be further
improved with SSE, MMX or 3Dnow.

Zoli




More information about the MPlayer-dev-eng mailing list