[MPlayer-dev-eng] [PATCH] Set liba52 output volume
Reimar.Doeffinger at stud.uni-karlsruhe.de
Tue Feb 15 19:52:43 CET 2005
On Tue, Feb 15, 2005 at 11:59:58AM -0600, Zoltan Hidvegi wrote:
> Reimar Döffinger wrote:
> > On Tue, Feb 15, 2005 at 04:22:41AM -0600, Zoltan Hidvegi wrote:
> > > Alex Beregszaszi wrote:
> > > I agree, but that's a less trivial change. The same is true for mp3
> > > and probably other formats, the best would be if they all produced
> > > float.
> > No, because the mp3 decoder doesn't use floats internally (which is
> > quite a good idea if you care about speed, especially on
> > e.g. "smaller" devices than the standard PC).
> Are you sure about that? mp3lib is full of floating point stuff.
No, I don't really know... Just the interface looked like it used mostly
> > But if it's an external lib and produces float it should not make
> > the conversions internally in the ad_* module, that is quite
> > nonsense.
> My patch does not add any internal conversions to the ad module. When
> you call the liba52 decoder, one of the arguments of the function is
> the level, which was always set to one before, my patch is trivial, it
> just sets the level to some other number. No work is done in the ad
> module. It it is still true that ad_liba52 can produce float, but if
> as Rich said, float support in libaf is broken, then it is still a
> problem. But I thought that -af volume with float kind of worked,
> I'll check it when I get home tonight.
I know that your patch doesn't add stupid conversions, but I know that
there are such internal conversions (at least in af_ladspa.c,
ad_libmad.c and the first version of ad_mpc.c)
Whether it works or not, it should be fixed instead at the place where
it is broken instead of constantly working around it.
Also I'd really like this functionality to be available in a more
general way... If you have time, maybe look if you can support for this
control to mixer.c? It would then only work with -softvol at first, but
better than nothing IMHO (and we already have so many options ;-) )
More information about the MPlayer-dev-eng