[MPlayer-dev-eng] Lots of stuff for NUT

[Michael Niedermayer]

Hi

On Sat, Dec 31, 2005 at 05:07:46PM -0500, Rich Felker wrote:
> On Sat, Dec 31, 2005 at 10:43:51PM +0200, Oded Shimon wrote:
> >      for(i=0; i<256; ){
> >          tmp_flag                        v
> >          tmp_fields                      v
> > -        if(tmp_fields>0) tmp_pts        s
> > -        if(tmp_fields>1) tmp_mul        v
> > -        if(tmp_fields>2) tmp_stream     v
> > -        if(tmp_fields>3) tmp_size       v
> > +        if(tmp_fields>0) tmp_mul        v
> > +        else tmp_mul=1
> > +        if(tmp_fields>1) tmp_sflag      v
> > +        else tmp_sflag=0
> > +        if(tmp_fields>2) tmp_pts        s
> > +        else tmp_pts=0
> > +        if(tmp_fields>3) tmp_stream     v
> > +        else tmp_stream=0
> > +        if(tmp_fields>4) tmp_size       v
> >          else tmp_size=0
> > -        if(tmp_fields>4) tmp_res        v
> > +        if(tmp_fields>5) tmp_res        v
> >          else tmp_res=0
> > -        if(tmp_fields>5) count          v
> > +        if(tmp_fields>6) count          v
> >          else count= tmp_mul - tmp_size
> > -        for(j=6; j<tmp_fields; j++){
> > +        for(j=7; j<tmp_fields; j++){
> >              tmp_reserved[i]             v
> >          }
> >          for(j=0; j<count && i<256; j++, i++){
> >              flags[i]= tmp_flag;
> > +            stream_flags[i]= tmp_sflag;
> >              stream_id_plus1[i]= tmp_stream;
> >              data_size_mul[i]= tmp_mul;
> >              data_size_lsb[i]= tmp_size + j;
> 
> Hmm, is this chunk for the best? Michael probably had reasons for the
> original way he did it..

yeah, and i dont remember them ;)


> 
> > +    for(i=0; i<stream_count; i++) {
> > +        j = 0;
> > +        while (j < syncpoints) {
> > +            repeat                      s
> > +            type = (repeat > 0)
> > +            repeat = abs(repeat)
> 
> Is there a reason you don't just use the low bit...

hmm, thinking about it now, i too think the low 2 bits would be cleaner
for type & that zero-ptr special case
maybe we could even get completely rid of get_s()?

[...]

-- 
Michael