[MPlayer-dev-eng] fix dynamic dvd drive selection on darwin

The Wanderer inverseparadox at comcast.net
Wed Dec 14 21:16:42 CET 2005


Emanuele Giaquinta wrote:

> Forget the previous patch for now; I've found that dvd_reader.c does
> not define SYS_BSD on osx, as it should, cause there is no test for
> __APPLE__ and __DARWIN__ is not defined on osx.  The attached patch
> fixes this.  Now, since the rdisk devices are raw, how can the
> dynamic dvd selection ever work?  DVDOpen just calls DVDOpenImageFile
> in the SYS_BSD case, which is the right one, and its return value is
> not a valid way to check that the device is associated to a dvd
> drive.  IMO it is better to revert to the traditional behaviour using
> rdisk1 as the default dvd device.

What's the status of this patch?

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.




More information about the MPlayer-dev-eng mailing list