[MPlayer-dev-eng] [PATCH] MPEG-ES in GXF demuxer

[Nico Sabbi]

Nico Sabbi wrote:

>>
>>       if(head==0x1B6) ++num_elementary_packets1B6;
>> +    else if (head == 0x1BC || head == 0x1BF) ++num_gxf_packets;
>> #if 1
>>     if( ( (num_elementary_packets100>50 && 
>> num_elementary_packets101>50) ||
>>           (num_elementary_packetsPES>50) ) && skipped>4000000){
>> @@ -844,6 +852,22 @@
>> };
>>
>>
>>  
>>
>
> uhm, 0x1b[cf] are startcodes used to identify PSM and padding streams, 
> so they are valid
> mpeg-ps stream identifiers. With your code there will be collisions 
> and fake detections.
>
> BTW, what's the format of gfx? can't you just associate the extension 
> with DEMUXER_TYPE_MPEG_ES?
> -demuxer 1 should play correctly the file. Testing now...
>
>

I can confirm that -demuxer 1 works with all those samples.
As far as only video streams are contained in gfx files your patch is 
unnecessary;
in all other cases you can implement a simple demuxer relying on a 
second probing function
to call in place on demux_mpg_probe(); the feeding and seeking functions 
can be the usual ones.

    Nico
 
 
 --
 Email.it, the professional e-mail, gratis per te: http://www.email.it/f
 
 Sponsor:
 Scopri il benessere che solo l’aloe vera regala al tuo corpo: cura la tua pelle
* Con la vasta gamma di prodotti che ti offre Erboristeria.com
 Clicca qui: http://adv.email.it/cgi-bin/foclick.cgi?mid=2380&d=25-8