[MPlayer-dev-eng] [PATCH] MPEG-ES in GXF demuxer

[Reimar Döffinger]

Hi,
On Thu, Aug 25, 2005 at 12:45:58PM +0200, Nico Sabbi wrote:
> I can confirm that -demuxer 1 works with all those samples.

No, it does not. Unless you consider gray bars and green flashes (with
libmpeg2 decoding) or hundreds of '[mpegvideo @ 0x86362e0]qscale == 0'
messages and jittery playback (with -vc ffmpeg12) working.

> in all other cases you can implement a simple demuxer relying on a 
> second probing function

Why duplicating code? It won't interfere with MPEG-PS detection as far
as I can tell, since that is done before (line 451/452).
Hmm... well, PES detection seems to be a bit below...
Anyway, even then it is possible to move the if () a few lines down, in
the worst case in the last place before failing autodetection.
Though maybe somebody with access to the specs can see if we currently
handle the 0x1BC and 0x1BF headers correctly? E.g. will the extradata
they contain be ended by any 0x1?? header or only by 0x100 as it seems
to be the case with gxf?

Greetings,
Reimar Döffinger