[MPlayer-dev-eng] Re: [PATCH] GNU/kFreeBSD support

[Diego Biurrun]

On Mon, Aug 22, 2005 at 10:53:44PM +0200, Robert Millan wrote:
> On Mon, Aug 22, 2005 at 04:22:11PM +0200, Diego Biurrun wrote:
> 
> > Are you sure you cannot just use #if defined(__GLIBC__) everywhere?
> 
> Sorry I don't know.  That should be answered by someone who works with Linux on
> a non-Glibc system.  I really don't mind as long as __GLIBC__ is present in
> these checks.

Both headers are from glibc on my system, I think it should be
__GLIBC__.  Rich, you don't use glibc, can you comment on this?

> > > -#ifdef __linux__
> > > +#if defined(__linux__) || (defined(__GLIBC__) && (defined(__FreeBSD_kernel__) || defined(__NetBSD_kernel__)))
> > 
> > Are you sure about this NetBSD change?
> 
> I'm the person who made the Debian GNU/kNetBSD port (the one based on Glibc).
> Although currently stalled, this system follows closely the configuration of
> its sister GNU/kFreeBSD, which provides Linux-style procfs.
> 
> If you feel this is too sloppy, though, I'd remove the __NetBSD_kernel__ part.

It looks as though just __GLIBC__ should be enough.

Diego