[MPlayer-dev-eng] Re: [PATCH] GNU/kFreeBSD support

[Robert Millan]

On Mon, Aug 22, 2005 at 04:22:11PM +0200, Diego Biurrun wrote:
> > 
> [...]
> 
> In these two cases you add #if defined(__GLIBC__) to #if defined(__linux__).
>
> [...]
> 
> Here you replace #if defined(__linux__) by #if defined(__GLIBC__).

The difference is that in the latter case, someone wrote a reply to this thread
saying only __GLIBC__ should be present, because uClibc doesn't have mntent.
So this is what I did.

> Are you sure you cannot just use #if defined(__GLIBC__) everywhere?

Sorry I don't know.  That should be answered by someone who works with Linux on
a non-Glibc system.  I really don't mind as long as __GLIBC__ is present in
these checks.

> > --- MPlayer-1.0pre7.old/loader/win32.c	2005-04-15 22:17:12.000000000 +0200
> > +++ MPlayer-1.0pre7/loader/win32.c	2005-08-22 17:42:45.000000000 +0200
> > @@ -1027,7 +1027,7 @@
> >  
> >  /* MPlayer: linux detection enabled (based on proc/cpuinfo) for checking
> >     fdiv_bug and fpu emulation flags -- alex/MPlayer */
> > -#ifdef __linux__
> > +#if defined(__linux__) || (defined(__GLIBC__) && (defined(__FreeBSD_kernel__) || defined(__NetBSD_kernel__)))
> 
> Are you sure about this NetBSD change?

I'm the person who made the Debian GNU/kNetBSD port (the one based on Glibc).
Although currently stalled, this system follows closely the configuration of
its sister GNU/kFreeBSD, which provides Linux-style procfs.

If you feel this is too sloppy, though, I'd remove the __NetBSD_kernel__ part.

-- 
Robert Millan