[MPlayer-dev-eng] Re: [PATCH] Pivoting

[Matthias Wieser]

Hi,

Am Freitag, 19. August 2005 16:40 schrieb Paweł Sakowski:

> Problem #2: aspect.c sets monitor_aspect to the fixed value of 4:3,
> unless overridden by command line or config file. It's a pretty
> arbitrary value, and it's wrong for my monitor (which has aspect ratio
> 5:4, when rotated: 4:5).

4:3 is wrong for many monitors, all 17" and 19" TFTs have an aspect ratio 
of 5:4, and many notebooks have wide screen TFTs.

> This problem isn't strictly related to 
> pivoting, basically 4:3 is not the right aspect ratio for some monitors
> (including mine, even if not rotated). I believe it would be a better
> heuristics to precalculate monitor_aspect by dividing width/height
> (thus pressuming that pixels are squares). This should give a
> satisfactory ratio for most displays; if it doesn't, there's always the
> possibility to override it manually.

This only works if you have a properly configured X11.

A better method probably would be to assume squared pixel if X11 does not 
provide any meaningfull information.
This would work for almost anybody and those few people who use an 
non-square-pixel-resolution should be able to use the -monitor-aspect 
option or to read 'man xorg.conf'.

It should not be the case that mplayer by default produces distorted 
pictures on most modern computers only because there are some 
non-square-pixel people who don't want to properly configure their X11 
server.

The question is: Should mplayer have sane defaults? If Yes, then let's 
make mlayer work out of the box on most computers. If someone uses 
10000x1000 pixel on it's 5:4 CRT it should be OK if he has to use 
MPlayer's -monitor-aspect option (or hast to do "vi xorg.conf").

> If you believe such behavior is 
> reasonable, I will be happy to prepare a patch implementing it.

Would be cool.

Regards,
  Matthias