[MPlayer-dev-eng] [PATCH] [RFC] Demuxer cleanup

Oded Shimon ods15 at ods15.dyndns.org
Fri Aug 5 15:15:34 CEST 2005


On Mon, Aug 01, 2005 at 12:06:59AM +0200, Roberto Togni wrote:
> New patch attached.
> 
> Ciao,
>  Roberto

You messed up xmms:
> -int demux_xmms_open(demuxer_t* demuxer) {
> +static int demux_xmms_open(demuxer_t* demuxer) {

> +  demux_open_xmms,

Doesn't compile.

BTW, if you're going modular, why not just do it all the way and use 
'open()', 'seek()', 'close()' and etc. for all formats instead of these 
long names. I think that's best, it's how it's done everywhere else in 
mplayer too...

and, Awesom patch!

- ods15




More information about the MPlayer-dev-eng mailing list