[MPlayer-dev-eng] [PATCH] [RFC] Demuxer cleanup

[Rich Felker]

On Mon, Aug 01, 2005 at 12:06:59AM +0200, Roberto Togni wrote:
> On Wed, 27 Jul 2005 08:27:45 +0200
> Nico Sabbi <nsabbi at tiscali.it> wrote:
> 
> > Roberto Togni wrote:
> > 
> > >It should be fixed, problem was in new_demuxers_demuxer() that
> creates a
> > >new demuxer without using the new_demuxer() function, so the desc
> field
> > >in demuxer_t struct was not filled correctly.
> > >I also moved desc init in new_demuxer(), that should fix a possible
> bug
> > >in ogg-in-avi.
> > >
> > >New patch attached.
> > >
> > >Ciao,
> > > Roberto
> > >  
> > >
> >
> >----------------------------------------------------------------------
> --
> > >
> > 
> > now -audiofile works correctly, but it crashes at uninit() time:
> > 
> > #0  0xb74e6b59 in mallopt () from /lib/tls/libc.so.6
> > #1  0xb74e4dda in free () from /lib/tls/libc.so.6
> > #2  0x0816cffe in free_demuxer (demuxer=0x880fd00) at demuxer.c:284
> > #3  0x080a24df in uninit_player (mask=3787) at mplayer.c:426
> > #4  0x080a2592 in exit_player_with_rc (how=0x855aa18 "Quit", rc=0) at
> > mplayer.c:494
> > #5  0x080a564b in main (argc=4, argv=0xbfc57824) at mplayer.c:2850
> > 
> Fixed, reintroducing a special behaviour in free_demuxer() for
> DEMUXER_TYPE_DEMUXERS to behave exactly like the old implementation.

Please be DAMN SURE you've got this right. :) There was a bug in here
sometime last year (multi free iirc) leading to nasty crash for some
users, and it took me a long time to find and fix it.

Rich