[MPlayer-dev-eng] [PATCH] synch to new x264 revision

[Guillaume POIRIER]

Le sam 25/09/2004 à 18:24, Diego Biurrun a écrit :
> Loren Merritt writes:
> > 
> >  .TP
> > -.B iframe=<value>
> > -I frame frequency (default: 60)
> > +.B keyint=<value>
> > +maximum interval between I-Frames
> > +Larger values save bits at the cost of seeking precision. (default: 150)
> 
> Nit: For consistency the period should be after the parentheses.

That's fixed on the CVS.


> > +.B frameref=<1\-15>
> > +Number of previous frames used as predictors in a P-frame (default: 1).
> > +This is effective in Anime, but seems to make little difference in 
> > +live-action source material.
> > +Some decoders are unable to deal with large frameref values.
> 
> Guillaume already committed this paragraph, you should remove it from
> your patch.

The goal of my patch was to have good descriptions based on Loren's
feedbacks ASAP, which is now done. Whenever the front-end will get
changed, only the options names will have to be changed.


> > -    {"iframe", &iframe, CONF_TYPE_INT, CONF_RANGE, 1, 24000000, NULL},
> > -    {"idrframe", &idrframe, CONF_TYPE_INT, CONF_RANGE, 1, 24000000, NULL},
> > +    {"keyint", &iframe, CONF_TYPE_INT, CONF_RANGE, 1, 24000000, NULL},
> > +    {"idrint", &idrframe, CONF_TYPE_INT, CONF_RANGE, 1, 24000000, NULL},
> 
> IMO (others may disagree) you should rename the variables as well,
> having variable names and option names differ is a recipe for code
> obfuscation IMO.

I agree with that too (even if others don't care about what I may think
on that field ;-).