[MPlayer-dev-eng] [PATCH] synch to new x264 revision

[Diego Biurrun]

Loren Merritt writes:
> 
> So I propose this patch.
> 
> --- DOCS/man/en/mplayer.1	22 Sep 2004 17:43:39 -0000	1.738
> +++ DOCS/man/en/mplayer.1	23 Sep 2004 18:17:11 -0000
> @@ -6734,18 +6734,13 @@
>  This is required if you want a CBR (constant bitrate) encode.
>  .
>  .TP
> -.B iframe=<value>
> -I frame frequency (default: 60)
> +.B keyint=<value>
> +maximum interval between I-Frames
> +Larger values save bits at the cost of seeking precision. (default: 150)

Nit: For consistency the period should be after the parentheses.

> +.B frameref=<1\-15>
> +Number of previous frames used as predictors in a P-frame (default: 1).
> +This is effective in Anime, but seems to make little difference in 
> +live-action source material.
> +Some decoders are unable to deal with large frameref values.

Guillaume already committed this paragraph, you should remove it from
your patch.

> -    {"iframe", &iframe, CONF_TYPE_INT, CONF_RANGE, 1, 24000000, NULL},
> -    {"idrframe", &idrframe, CONF_TYPE_INT, CONF_RANGE, 1, 24000000, NULL},
> +    {"keyint", &iframe, CONF_TYPE_INT, CONF_RANGE, 1, 24000000, NULL},
> +    {"idrint", &idrframe, CONF_TYPE_INT, CONF_RANGE, 1, 24000000, NULL},

IMO (others may disagree) you should rename the variables as well,
having variable names and option names differ is a recipe for code
obfuscation IMO.

Diego