[MPlayer-dev-eng] [PATCH] improving MP3 detection

Attila Kinali attila at kinali.ch
Mon Sep 20 15:33:34 CEST 2004


On Mon, Sep 13, 2004 at 08:48:53PM +0200, Reimar Döffinger wrote:
 
> As far as I can tell, the old code did the same checks, but _after_ the 
> detection itself, this should just move this check to a point where we 
> can still search for a better alternative (i.e. another mp3 header that 
> has 5 consecutive good frames). What might be worth discussing is that 
> it changes the detection to always search at most the first 30000 bytes 
> of any file...

Let me rephrase my concern: is it possible that this patch misdetects
a broken mpeg file as mp3 ?

> And concerning documenting: I think I didn't add anything global ;-)

That does not matter at all ;)

			Attila Kinali




More information about the MPlayer-dev-eng mailing list