[MPlayer-dev-eng] [PATCH] improving MP3 detection

[Reimar Döffinger]

Hi,

>>the following patch improves MP3 detection. It is a bit more 
>>complicated, because it avoids seeking backwards as much as possible. 
>>Even with linear streams only as many frames as neccessary for reliable 
>>detection will be skipped.
>>Please comment.
> 
> Does it also work with heavily broken mpeg files ? Ie does it still
> detect them properly ? Arpi has rejected quite a few mp3 detection
> improvments in the past because they would japordize proper mpeg
> detection.

As far as I can tell, the old code did the same checks, but _after_ the 
detection itself, this should just move this check to a point where we 
can still search for a better alternative (i.e. another mp3 header that 
has 5 consecutive good frames). What might be worth discussing is that 
it changes the detection to always search at most the first 30000 bytes 
of any file...

And concerning documenting: I think I didn't add anything global ;-)

Greetings,
Reimar Döffinger