[MPlayer-dev-eng] [PATCH] shufle for gui playlist ENGLISH

Rojer myself at rojer.pp.ru
Sun Sep 19 19:54:39 CEST 2004


Diego Biurrun wrote:
> Rojer writes:
> 
>>as a  convert from winamp world,
>>i missed the shuffle faeture very much.
>>so i added it.
>>seems to work ok for me.
> 
> 
> It does not work for me.  When I press the shuffle button nothing
> happens.

Shuffle should appear as a check-item in the dropdown menu.
when checked, it basically makes prev/next buttons to skip to random 
track when pressed.
more precisely, there is a "window" of 16 (GUI_SHUFFLE_WINDOW_SIZE) 
items with current item indexed by "slider" (swi variable).
when the slider reaches either edge of the "window", the next item to be 
played is determined by either picking a random one (shuffle is checked) 
or the next one (shuffle unchecked).
this adds convenience (compared to just picking random item every time) 
in that you can get back to "what was that previous song played" by 
simply pressing prev button.

> 
> 
>>+   case gtkGetNextPlItem: 
>>+   case gtkGetPrevPlItem:
> 
 > This line is duplicated.  Just remove the first, it's the one with the
 > trailing whitespace ;-)

this is not a dupe, these are cases for Next and Prev sharing similar code.

> Please just update the English messages.

ok, i just thought i should add it to every file so not to break the 
build for other languages.
removed.

-- 
Deomid Ryabkov aka Rojer
myself at rojer.pp.ru
rojer at sysadmins.ru


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: shuffle2.patch
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040919/4530a86a/attachment.txt>


More information about the MPlayer-dev-eng mailing list