[MPlayer-dev-eng] [PATCH] New VO drivers.

[Ivo]

On Friday 17 September 2004 20:22, Diego Biurrun wrote:
> Ivo writes:
> > I will leave vo_pgm and vo_md5 intact for the moment. What path do we
> > have to follow to remove these (since they become obsolete)? To keep
> > the user informed, the only way I see is to delete all content of the
> > functions inside those vo drivers and have preinit() write a message to
> > the console and exit the player.
>
> Well, you could just update vo_pgm and vo_md5, couldn't you?

That would be silly IMHO because the new drivers have the same functionality 
and can do more things (like PPM's and ASCII mode), combined with a better 
design (faster/less memory).

> BTW, why do you reimplement MD5 instead of relying on an external
> program?

As Richard already pointed out, it's bad to assume someone has a certain 
utility installed. Also, the old implementation was terribly slow. It first 
called vo_pgm, which made a local copy of a YUV frame, wrote it to disk and 
then ran md5sum on that file. The new implementation works directly on the 
mp_image and hence it is much faster and does not depend on another vo 
driver or an external program.

> Otherwise I see nothing wrong (OK, I could start talking about
> trailing whitespace, but I won't ;-), yet this means nothing, besides
> I did not test it.

I will commit it this weekend, so people can easily test it. I have tested 
it quite extensively myself already, but I know what can happen as soon as 
others start using it :-)

> Unless you wish to unleash the wrath of the chief documentation
> maintainer ;-)

I'll update it before I commit the sourcecode and post it to -docs to be 
reviewed, rephrased and nitpicked :-)

--Ivo