[MPlayer-dev-eng] [PATCH] New VO drivers.

Ivo ivop at euronet.nl
Fri Sep 17 03:48:21 CEST 2004


Second reply to my own e-mail ;)

Anyway, I have re-implemented both vo_pnm and vo_md5sum. Now, they don't 
maintain a local copy of the current frame when in YV12 mode, don't use 
draw_frame() or draw_slice(), but act on VOCTRL_DRAW_IMAGE and the 
mp_image_t * that's passed on to it. Huge improvement in speed and memory 
usage for yv12 modes (pnm:pgm, pnm:pgmyuv and when yv12 data is feeded to 
md5sum). Also, I added almost paranoid error checking. If something goes 
wrong, it is detected and handled.

Any comments, objections or suggestions to/on this code? If not, I will 
commit it in a few days.

I will leave vo_pgm and vo_md5 intact for the moment. What path do we have 
to follow to remove these (since they become obsolete)? To keep the user 
informed, the only way I see is to delete all content of the functions 
inside those vo drivers and have preinit() write a message to the console 
and exit the player.

Oh, and I will update the manual page after commiting the code :)

The new non-diff files attached to this e-mail should be placed in 
main/libvo/.

--Ivo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cvsdiff-u.vo_pnm.vo_md5sum
Type: text/x-diff
Size: 2192 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040917/8e374172/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vo_md5sum.c
Type: text/x-csrc
Size: 10181 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040917/8e374172/attachment.c>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vo_pnm.c
Type: text/x-csrc
Size: 22817 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040917/8e374172/attachment-0001.c>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: md5sum.c
Type: text/x-csrc
Size: 19673 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040917/8e374172/attachment-0002.c>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: md5sum.h
Type: text/x-chdr
Size: 8467 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040917/8e374172/attachment.h>


More information about the MPlayer-dev-eng mailing list