[MPlayer-dev-eng] [PATCH] New VO drivers.

[Ivo]

On Wednesday 15 September 2004 02:01, Ivo wrote:
> On Wednesday 15 September 2004 01:46, D Richard Felker III wrote:
> > just don't implement draw_slice and you'll get full frames via
> > draw_frame.
>
> That doesn't seem to work for planar formats, only for packed ones, but
> I'm probably doing something wrong. I'll look into it, because not only
> will it save space, it also will be a huge speed improvement.

Ok, I've read some more code, and I think I have to ditch the whole 
draw_frame/draw_slice thing if I want to save memory and increase speed. I 
see no way to get planar YV12 in draw_frame. I suppose it's impossible by 
design. Draw_frame is for packed formats only. (BTW maybe you meant 
draw_image all along?)

I have to shuffle some code around and change a few things and implement 
VOCTRL_DRAW_IMAGE and draw_image(). It's some more work (and some things 
are a bit fuzzy because they lack documentation), but I think it's worth 
it. I think the code will end up more compact and robust. The same has to 
be done for vo_pnm btw. Just use mpi->planes[] to build the output file 
on-the-fly.

So, last patch can be discarded. I'll get back to you :-)

--Ivo