[MPlayer-dev-eng] [PATCH] EDL fix harcoded translatable messages
Diego Biurrun
diego at biurrun.de
Wed Sep 15 09:09:27 CEST 2004
Reynaldo H. Verdejo Pinochet writes:
> On Tue, Sep 14, 2004 at 12:25:58PM +0200, Diego Biurrun wrote:
> > Please read what I just sent to dev-eng about splitting up patches and
> > follow the advice I give there. I'm currently too lazy to handle this
> > split-up patch, besides, I could not resist to pick some more nits, so
> > the patch is refused for now, sorry.
> >
> > Please send in an updated version, I'll apply.
> >
> Ok, noprob
>
> Here is the patch on 1 file.
That's much better, thank you. But you just ignored my other
suggestions. OK, they were mostly cosmetic and thus I have applied
your patch to my local tree with my modifications, but I would like
you to clear up the following comment:
> +int edl_mute_count = 0; /// even number when mute has been matched mute/unmute
What you are trying to say here is shrouded in complete mystery (at
least to me), please explain and I will commit your patch.
Diego
More information about the MPlayer-dev-eng
mailing list