[MPlayer-dev-eng] [PATCH] unbreak libmpcodecs/ve_x264.c

[Diego Biurrun]

Ivo writes:
> On Tuesday 14 September 2004 19:38, Jan Knutar wrote:
> > >+#ifdef HAVE_X264
> > > #include <stdio.h>
> >
> > There are several other modules which include headers even if they
> > aren't being compiled in. I always thought there was some hidden reason
> > that I didn't understand. Is there a reason for it or not?
> 
> I don't know for sure, but I don't think so. It's probably due to the fact 
> that people start writing their code based on a framework of another 
> filter, demuxer, codec, whatever and keep all the includes that were there 
> in the original. Some might not be needed for the new code, but they are 
> included anyway. Maybe somebody should check all files to see whether they 
> include too much or not. Might save some compile time :-)

Actually, I have been doing just that at SUCON in a free minute.

I've tried to move the decision what gets compiled when into the build
system where it belongs IMHO.  Yes, it will save some compilation time
and make a lot of #ifdef statements in the code unnecessary.  It's not
finished yet, though.

Diego