[MPlayer-dev-eng] [PATCH] New VO drivers.

Ivo ivop at euronet.nl
Wed Sep 15 00:12:25 CEST 2004


On Tuesday 14 September 2004 16:23, D Richard Felker III wrote:
> use draw_frame or something instead, probably... by the time flip_page
> is called, you own't have the picture anymore unless you wastefully
> made a copy of it.

I use draw_frame when the input is packed RGB24 and don't copy any data. For 
planar YV12 I maintain a local copy and update it everytime draw_slice is 
called. I believe all vo_ drivers that handle planar YV12 have a local copy 
of the current frame and draw the slices on that. If there's an easier way 
to obtain a full planar YV12 frame, please let me know. I don't want to 
calculate the MD5 sum as a progression on all slices of one frame, because 
if the slices are drawn if a different order in future code, the MD5 sums 
won't match anymore.

For now, this is the updated patch. I removed the rgb and yuv suboptions. It 
just acts upon the data it gets feeded (-vf rgb24 or -vf yv12). I also 
fixed a sig11 in uninit of vo_md5sums. No output file is opened if the 
colorspace is unsupported, hence it doesn't have to close it at uninit.

Any more comments or suggestions?

--Ivo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cvsdiff-u.vo_pnm.vo_md5sum
Type: text/x-diff
Size: 2192 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040915/9492a238/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: md5sum.c
Type: text/x-csrc
Size: 19673 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040915/9492a238/attachment.c>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vo_md5sum.c
Type: text/x-csrc
Size: 9268 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040915/9492a238/attachment-0001.c>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: md5sum.h
Type: text/x-chdr
Size: 8467 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040915/9492a238/attachment.h>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vo_pnm.c
Type: text/x-csrc
Size: 20658 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040915/9492a238/attachment-0002.c>


More information about the MPlayer-dev-eng mailing list