[MPlayer-dev-eng] [PATCH] New VO drivers.

D Richard Felker III dalias at aerifal.cx
Tue Sep 14 16:23:11 CEST 2004


On Tue, Sep 14, 2004 at 02:55:09PM +0200, Ivo wrote:
> On Tuesday 14 September 2004 06:20, D Richard Felker III wrote:
> > > -vo md5sum:suboptions :
> > >
> > > 	rgb		- calculate sums on RGB24 frames
> > > 	yuv		- calculate sums on YV12 frames
> >
> > i'm mildly against rgb/yuv options. vo_md5sum should just use whatever
> > format is passed into it. the user can control this with vf_format
> > and/or vf_scale if needed.
> 
> Ok. It's easy to remove these options and let the user decide what to feed 
> it and the driver react on that.
> 
> Also, I made a mistake in the code. Draw_slice() can be called multiple 
> times for one frame (although it wasn't with my test data), so I have to 
> move parts of the code to flip_page(). 

use draw_frame or something instead, probably... by the time flip_page
is called, you own't have the picture anymore unless you wastefully
made a copy of it.

rich




More information about the MPlayer-dev-eng mailing list